Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match the Rails name for sqlite in $DB #65

Closed
wants to merge 1 commit into from

Conversation

elia
Copy link
Member

@elia elia commented Nov 15, 2022

Summary

We traditionally used sqlite and had code to convert it to sqlite3 when using it as a rails new --database=… option.
Moving to use the same naming simplifies the setup. Sandbox and solidus_core script should already be compatible with the rails-compatible name.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • I have written a thorough PR description.
  • I have kept my commits small and atomic.
  • I have used clear, explanatory commit messages.

The following are not always needed (cross them out if they are not):

  • I have added automated tests to cover my changes.
  • I have attached screenshots to demo visual changes.
  • I have opened a PR to update the guides.
  • I have updated the README to account for my changes.

Sandbox and solidus_core script should already be compatible with the
rails-compatible name.
@elia
Copy link
Member Author

elia commented Nov 15, 2022

Reopening from a branch in the same repo so the publishing CI step will work, see #66.

@elia elia closed this Nov 15, 2022
@elia elia deleted the elia/standard-sqlite-db-name branch November 15, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant