Raise on deprecation when SOLIDUS_RAISE_DEPRECATIONS set
#5813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
forkata
changed the title
SOLIDUS_RAISE_DEPRECATIONS set
forkata
force-pushed
the
raise-error-with-spree-deprecator
branch
from
e798682 to
6877d7a
Compare
benjaminwil
reviewed
Aug 7, 2024
|
It looks like this change has exposed some other tests that should have been raising exceptions but were not. (Because So we'll need to go back and fix those up before merging, it seems. |
|
Thanks for this! We should restore the previous behavior to spot failing specs for deprecations, like it's already happening it seems. Thanks again. ❤️ |
mamhoff
added a commit
to mamhoff/solidus
that referenced
this pull request
Aug 8, 2024
This spec still used one of the old extension points for the promotion system, and solidusio#5813 exposed that.
jarednorman
approved these changes
Aug 8, 2024
|
Looks like we just need to rebase once #5814 is merged and all will be okay. |
mamhoff
added a commit
to mamhoff/solidus
that referenced
this pull request
Aug 8, 2024
This spec still used one of the old extension points for the promotion system, and solidusio#5813 exposed that.
|
We can rebase now, thanks! |
benjaminwil
force-pushed
the
raise-error-with-spree-deprecator
branch
from
6877d7a to
44f1b9d
Compare
These tests were written to aid in debugging an issue: solidusio#5766 Here we expose an issue using a pending test, with the ENV that allows overriding of the default deprecation behavior, which gets lost during the initialization of the `DummyApp`. Co-authored-by: Chris Todorov <[email protected]>
This change fixes issue solidusio#5766 which seems to be caused by the deprecator behaviour being lost when the dummy app is initialized. By moving the code that sets the behaviour to happen after the initialization of the dummy app we can avoid this issue. Co-authored-by: Benjamin Willems <[email protected]>
forkata
force-pushed
the
raise-error-with-spree-deprecator
branch
from
44f1b9d to
586c519
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5813 +/- ##
=======================================
Coverage 88.74% 88.74%
=======================================
Files 735 735
Lines 17172 17172
=======================================
Hits 15239 15239
Misses 1933 1933 ☔ View full report in Codecov by Sentry. |
MadelineCollier
approved these changes
Aug 16, 2024
kennyadsl
approved these changes
Aug 19, 2024
mamhoff
added a commit
to mamhoff/solidus
that referenced
this pull request
Sep 2, 2024
This calculator uses the `eligible` API from `Spree::Adjustment`, which in a system with the new promotions system will not be necessary. This hasn't been caught before because deprecation warnings did not raise until solidusio#5813 was merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5766
This issue can be reproduced on the first commit by running the specs with the environment variable to override deprecation behaviour, as such
which produces the following output
We were able to fix this issue by moving the code that sets the deprecation behaviour after the
DummyAppis initialized, which seems to reset that.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: