Make Controller Helpers autoloadable

[mamhoff]

There's no real good reason to keep these files in lib and require them on app startup. Let's put them in app/ and let Zeitwerk handle their loading.

[kennyadsl]

I think the reason to have them in lib is to being easily loadable by host applications and extensions. Can we do the same now?

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.39%. Comparing base (85a0a25) to head (39e835b).

Files with missing lines	Patch %	Lines
...pp/helpers/spree/core/controller_helpers/common.rb	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6062      +/-   ##
==========================================
- Coverage   92.52%   89.39%   -3.13%     
==========================================
  Files         385      791     +406     
  Lines        8400    18274    +9874     
==========================================
+ Hits         7772    16336    +8564     
- Misses        628     1938    +1310     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mamhoff]

Yes, they have the same loading characteristics as e.g. Spree::Order - available from anywhere simply by invoking the constant names.

[kennyadsl]

Right, we just don't need any require before using it now. What about keeping the files and print a warning telling people that they can remove the require now? I'm afraid this might break all stores requiring the lib files.

[mamhoff]

Right, we just don't need any require before using it now. What about keeping the files and print a warning telling people that they can remove the require now? I'm afraid this might break all stores requiring the lib files.

Good catch. I've re-added the files in lib with just a deprecation warning. There's even a test documenting what happens.

[tvdeyen]

Thanks.