simplify require_shipping? check in PaypalOrder with separated step_n…

…ames method
solidusio · Nov 22, 2022 · 7f1439a · 7f1439a
1 parent 2b9ef4c
commit 7f1439a
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/app/models/solidus_paypal_commerce_platform/paypal_order.rb b/app/models/solidus_paypal_commerce_platform/paypal_order.rb
@@ -118,9 +118,11 @@ def application_context
     end
 
     def require_shipping?
-      step_names = @order ? @order.checkout_steps : ::Spree::Order.checkout_steps.keys
+      step_names.include? :delivery
+    end
 
-      step_names.include? 'delivery'
+    def step_names
+      @order ? @order.checkout_steps.map(&:to_sym) : ::Spree::Order.checkout_steps.keys
     end
   end
 end