-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on truncate_html
gem
#387
base: main
Are you sure you want to change the base?
Remove dependency on truncate_html
gem
#387
Conversation
@jarednorman can you retry the build here 🙏🏼 We identified a flaky test and working with @benjaminwil to fix it, but it is not related to these changes. |
I don't have permission on CircleCI. You'll have to amend your commit and re-push. |
Re-running specs, but a rebase is needed now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
==========================================
- Coverage 95.98% 95.95% -0.04%
==========================================
Files 207 206 -1
Lines 4880 4815 -65
==========================================
- Hits 4684 4620 -64
+ Misses 196 195 -1 ☔ View full report in Codecov by Sentry. |
This doesn't seem to be used anywhere and is a relic from a 2013 change[^1]. Additionally, this can now be achieved purely using Rails built-in helpers, as such ```ruby include ActionView::Helpers::SanitizeHelper include ActionView::Helpers::TextHelper sanitize("<div> hello world".truncate(10)) ``` [^1]: spree/spree#2518 Co-authored-by: Benjamin Willems <[email protected]> Co-authored-by: Andrew Stewart <[email protected]>
833eaa0
to
99a8930
Compare
Rebased. 👍 |
@jarednorman @kennyadsl also this one looks ready for merge, but I am unsure on the test. Could you give a look and merge if possible. |
Summary
This doesn't seem to be used anywhere and is a relic from a 2013
change1.
Additionally, this can now be achieved purely using Rails built-in
helpers, as such
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed:
Footnotes
https://github.com/spree/spree/pull/2518 ↩