Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean HTML headings to align with SEO best practices #408

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fthobe
Copy link
Contributor

@fthobe fthobe commented Jan 9, 2025

Summary

After long discussions in #377 it was agreed to implement changes in accordance with Issue #375 to clean HTML Headings for SEO in preparation of structured data update.

The contained commit practically does the following:

  • where appropriate it removes html heading tags from html to allow a concentration of admin panel controlled SEO elements (Taxon Name / Product Name)
  • elements relevant only for structured data such as prices, product names in taxon pages,.... have been entirely stripped of H tags in favour in page resource controls
  • where it was possible H tags have simply been substituted with span, where not more complex html invoking tailwind classes has been added
  • to avoid visual change even if a H tag was converted to span, the tailwind class text-hX has been kept

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant