Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run legacy promotion handler "cart" if legacy promo system present #309

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Run legacy promotion handler "cart" if legacy promo system present #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/solidus_subscriptions/checkout.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ def populate_order(order)
end

def finalize_order(order)
# Rerun the legacy promotion handler
# `solidus_promotions` does not need this handler, and will pickup promotions in `order.recalculate`
::Spree::PromotionHandler::Cart.new(order).activate if defined?(::Spree::PromotionHandler::Cart)
order.recalculate

order.checkout_steps[0...-1].each do
Expand Down
3 changes: 3 additions & 0 deletions lib/solidus_subscriptions/subscription_line_item_builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ def create_subscription_line_item(line_item)
subscription_params.merge(spree_line_item: line_item)
)

# Rerun the legacy promotion handler to pickup subscription promotions
# `solidus_promotions` does not need this handler, and will pickup promotions in `order.recalculate`
::Spree::PromotionHandler::Cart.new(line_item.order).activate if defined?(::Spree::PromotionHandler::Cart)
line_item.order.recalculate
end

Expand Down