Re-enable flickwerk-style patches #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than iterating over all patches, we can tell Flickwerk upfront what to replace.
This should not mess with load order the way 0.2 did.
mamhoff
force-pushed
the
re-enable-flickwerk
branch
from
f64be5e to
6786a9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We found out that we need to find and load patches in a config.to_prepare hook - the hard way, because Flickwerk 0.2 broke quite a few other gems and extensions.
The new release has that fixes and offers a new API for class aliases like
"Spree.user_class" => "Spree::User".Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: