Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Use Webpack for asset management #5454

Closed
4 tasks done
silasjoisten opened this issue Jan 28, 2019 · 6 comments
Closed
4 tasks done

[RFC] Use Webpack for asset management #5454

silasjoisten opened this issue Jan 28, 2019 · 6 comments

Comments

@silasjoisten
Copy link
Contributor

silasjoisten commented Jan 28, 2019

Feature Request

I would like to provide a PR which implement the usage webpack encore

  • Setup webpack encore
  • install vendors via yarn (remove from Resources/public/vendor)
  • use custom stylesheets, javascript files also via webpack
  • remove bower

Dependencies

Vendors

  • AdminLTE2
  • famfamfam (still needed?)
  • jQuery
  • jQuery form
  • jQuery scrollTo
  • jQuery UI
  • mansonry
  • readmoreJS
  • slimScroll
  • waypoints
  • xEditable
  • iCheck
  • Bootstrap (corebundle)
  • fontawesome (corebundle)
  • ionicons (corebundle)
  • datetimepicker (corebundle)
  • select2 (corebundle)
  • momentjs (corebundle)

Custom

  • colors.css
  • layout.css
  • styles.css
  • tree.css
  • jquery.confirmExit.js
  • Admin.js
  • sidebar.js
  • treeview.js

Benefits

  • only one css, javascript file
  • easier adding styles, javascripts
  • usage of sass or less
  • easy update of dependencies for example jQuery

Questions

  • which branch i should use master, 4.x, 3.x?

What would you say?

@kunicmarko20
Copy link
Contributor

@core23 had a similar idea if I am not mistaken #5299

@core23
Copy link
Member

core23 commented Jan 28, 2019

If you have an idea how to do it. Feel free 👍

@silasjoisten
Copy link
Contributor Author

Yea i would have an idea. Shall i open an PR? and from which branch? master or 3.x or 4.x?

@core23
Copy link
Member

core23 commented Jan 28, 2019

Because it will be a BC break => master

@stale
Copy link

stale bot commented Jan 30, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@VincentLanglet
Copy link
Member

Closing in favor of #7049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants