Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SonataAdminBundle 4.0 WebpackEncore configuration #714

Conversation

silasjoisten
Copy link
Contributor

Q A
License MIT

Recipe for SonataAdminBundle with WebpackEncore configuration

see sonata-project/SonataAdminBundle#5461

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Nyholm
Copy link
Member

Nyholm commented Aug 13, 2019

I think I would be happy with this

@silasjoisten
Copy link
Contributor Author

I think I would be happy with this

What do you mean?

@Nyholm
Copy link
Member

Nyholm commented Aug 14, 2019

You have made the PR as "draft".
Im just saying. If you make it non-draft and CI is green, I would be happy to merge it.

@silasjoisten
Copy link
Contributor Author

Is there any problem when SonataAdminBundle ^4.0 isn't released yet?

@Nyholm
Copy link
Member

Nyholm commented Aug 15, 2019

Correct, If 4.0 is not released then CI will be red.

@silasjoisten
Copy link
Contributor Author

I will convert it to a PR if 4.0 is released.

@Nyholm
Copy link
Member

Nyholm commented Nov 28, 2019

Any updates of SonataAdminBundle 4.0?

@Nyholm
Copy link
Member

Nyholm commented Jan 26, 2020

Friendly ping

@silasjoisten
Copy link
Contributor Author

Friendly ping

Hi its not released yet. I did not forget this PR. :)

@OskarStark
Copy link
Contributor

We are still working in the corresponding PR, but almost good to go 👍🏻

@Nyholm
Copy link
Member

Nyholm commented Sep 24, 2020

Friendly reminder to complete this PR.

@Nyholm
Copy link
Member

Nyholm commented Aug 2, 2021

Feel free to make a new PR if you are still interested to finish this.

@Nyholm Nyholm closed this Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants