Fix some fa icons and add compatibility layer to admin-lte #7136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordisala1991
changed the title
jordisala1991
force-pushed
the
hotfix/fa5
branch
from
eb2364b to
c373186
Compare
jordisala1991
referenced
this pull request
Apr 29, 2021
Use new package name for font awesome and also add a compatibility layer with version 4, because we have a lot of icons placed around all Sonata bundles and packages
VincentLanglet
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this applies to master.
Part of #7049
I missed some "fa" classes and some icons unchanged. Also I have added compatibility layer with all admin-lte v2 styles that did account for "fa" class but not for "fas"