Add swss::Table to c api #964
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
It is only used for key/field names, so this keeps it consistent with other class apis
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
approved these changes
Jan 8, 2025
liuh-80
reviewed
Jan 9, 2025
| @@ -31,3 +31,7 @@ void SWSSFieldValueArray_free(SWSSFieldValueArray arr) { | |||
| void SWSSKeyOpFieldValuesArray_free(SWSSKeyOpFieldValuesArray kfvs) { | |||
| SWSSTry(delete[] kfvs.data); | |||
| } | |||
|
|
|||
| void SWSSStringArray_free(SWSSStringArray arr) { | |||
| SWSSTry(delete[] arr.data); | |||
There was a problem hiding this comment.
This is a "const char **data;", do you need delete all string pointer in this array first?
There was a problem hiding this comment.
The c api free functions don't do that because the data is sometimes user-owned. The behavior is expressed in the header file comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.