Improve log information when exception is caught in Orch2 class #3401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
approved these changes
Dec 2, 2024
|
Bypassing coverage since its an exception path |
bradh352
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Dec 4, 2024
…c-net#3401) What I did Add the information regarding which class the exception is originated from when Orch2 catches an exception. Why I did it An Exception was thrown, and the error log given was: ERR swss#orchagent: :- doTask: Logic error: map::at This gives almost no information on where the exception happened.
bradh352
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Dec 4, 2024
…c-net#3401) What I did Add the information regarding which class the exception is originated from when Orch2 catches an exception. Why I did it An Exception was thrown, and the error log given was: ERR swss#orchagent: :- doTask: Logic error: map::at This gives almost no information on where the exception happened.
divyachandralekha
pushed a commit
to divyachandralekha/sonic-swss
that referenced
this pull request
Dec 12, 2024
…c-net#3401) What I did Add the information regarding which class the exception is originated from when Orch2 catches an exception. Why I did it An Exception was thrown, and the error log given was: ERR swss#orchagent: :- doTask: Logic error: map::at This gives almost no information on where the exception happened.
divyachandralekha
pushed a commit
to divyachandralekha/sonic-swss
that referenced
this pull request
Dec 12, 2024
…c-net#3401) What I did Add the information regarding which class the exception is originated from when Orch2 catches an exception. Why I did it An Exception was thrown, and the error log given was: ERR swss#orchagent: :- doTask: Logic error: map::at This gives almost no information on where the exception happened.
|
@DavidZagury, @prsunny I added the cherry-pick label for 202411 branch. It will not be cherry-picked to 202405 as it's considered as an enhancement. |
@bingwang-ms there is no need to cherry pick to 202411 as this is already part of the branch. This was merged before the branch out. |
mssonicbld
pushed a commit
to mssonicbld/sonic-swss
that referenced
this pull request
Dec 24, 2024
…c-net#3401) What I did Add the information regarding which class the exception is originated from when Orch2 catches an exception. Why I did it An Exception was thrown, and the error log given was: ERR swss#orchagent: :- doTask: Logic error: map::at This gives almost no information on where the exception happened.
|
Cherry-pick PR to 202405: #3441 |
mssonicbld
pushed a commit
that referenced
this pull request
Dec 24, 2024
What I did Add the information regarding which class the exception is originated from when Orch2 catches an exception. Why I did it An Exception was thrown, and the error log given was: ERR swss#orchagent: :- doTask: Logic error: map::at This gives almost no information on where the exception happened.
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add the information regarding which class the exception is originated from when Orch2 catches an exception.
Why I did it
An Exception was thrown, and the error log given was:
ERR swss#orchagent: :- doTask: Logic error: map::atThis gives almost no information on where the exception happened.
How I verified it
Compiled SWSS which I forced an exception to be thrown from addOperation in VxlanTunnelOrch.
The log resulted is:
ERR swss#orchagent: :- doTask: Logic error in 15VxlanTunnelOrch: map::atWhich focus you to a specific class.
Bigger improvement would need a larger refactor.
Details if related