[orchagent] Fix: ERR swss#orchagent: :- setPortPvid: pvid setting for tunnel Port_EVPN_XXX is not allowed #3402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prsunny looks like the internal conflict was resolved since it was merged to main now. Please review and hopefully merge. |
…_EVPN_XXX is not allowed Tunnel ports are always tagged and can't be created as untagged. But the code currently tries to set a pvid on a tunnel which is disallowed leading to an error in the logs. This is a simple fix to get rid of the error in the logs. It does not actually change behavior in any way other than getting rid of an error thus helping debugability. Signed-off-by: Brad House (@bradh352)
bradh352
force-pushed
the
tunnelport-nopvid
branch
from
e994009 to
1f15ade
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
rebased on top of current master to get rid of merged stuff that is now upstream |
|
@prsunny is this good to go? |
bradh352
added a commit
to bradh352/sonic-swss
that referenced
this pull request
Dec 24, 2024
… tunnel Port_EVPN_XXX is not allowed (PR sonic-net#3402) Tunnel ports are always tagged and can't be created as untagged. But the code currently tries to set a pvid on a tunnel which is disallowed leading to an error in the logs. This is a simple fix to get rid of the error in the logs. It does not actually change behavior in any way other than getting rid of an error thus helping debugability. Signed-off-by: Brad House (@bradh352)
bradh352
added a commit
to bradh352/sonic-swss
that referenced
this pull request
Dec 24, 2024
… tunnel Port_EVPN_XXX is not allowed (PR sonic-net#3402) Tunnel ports are always tagged and can't be created as untagged. But the code currently tries to set a pvid on a tunnel which is disallowed leading to an error in the logs. This is a simple fix to get rid of the error in the logs. It does not actually change behavior in any way other than getting rid of an error thus helping debugability. Signed-off-by: Brad House (@bradh352)
bradh352
added a commit
to bradh352/sonic-swss
that referenced
this pull request
Dec 24, 2024
… tunnel Port_EVPN_XXX is not allowed (PR sonic-net#3402) Tunnel ports are always tagged and can't be created as untagged. But the code currently tries to set a pvid on a tunnel which is disallowed leading to an error in the logs. This is a simple fix to get rid of the error in the logs. It does not actually change behavior in any way other than getting rid of an error thus helping debugability. Signed-off-by: Brad House (@bradh352)
bradh352
added a commit
to bradh352/sonic-swss
that referenced
this pull request
Dec 24, 2024
… tunnel Port_EVPN_XXX is not allowed (PR sonic-net#3402) Tunnel ports are always tagged and can't be created as untagged. But the code currently tries to set a pvid on a tunnel which is disallowed leading to an error in the logs. This is a simple fix to get rid of the error in the logs. It does not actually change behavior in any way other than getting rid of an error thus helping debugability. Signed-off-by: Brad House (@bradh352)
bradh352
added a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 2, 2025
… tunnel Port_EVPN_XXX is not allowed (PR sonic-net#3402) Tunnel ports are always tagged and can't be created as untagged. But the code currently tries to set a pvid on a tunnel which is disallowed leading to an error in the logs. This is a simple fix to get rid of the error in the logs. It does not actually change behavior in any way other than getting rid of an error thus helping debugability. Signed-off-by: Brad House (@bradh352)
bradh352
added a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 2, 2025
… tunnel Port_EVPN_XXX is not allowed (PR sonic-net#3402) Tunnel ports are always tagged and can't be created as untagged. But the code currently tries to set a pvid on a tunnel which is disallowed leading to an error in the logs. This is a simple fix to get rid of the error in the logs. It does not actually change behavior in any way other than getting rid of an error thus helping debugability. Signed-off-by: Brad House (@bradh352)
|
@srj102 , would you review or assign someone? seems some defaults values are changed for evpn scenario |
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 7, 2025
… tunnel Port_EVPN_XXX is not allowed (PR sonic-net#3402) Tunnel ports are always tagged and can't be created as untagged. But the code currently tries to set a pvid on a tunnel which is disallowed leading to an error in the logs. This is a simple fix to get rid of the error in the logs. It does not actually change behavior in any way other than getting rid of an error thus helping debugability. Signed-off-by: Brad House (@bradh352)
Will review this. Thanks |
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 9, 2025
… tunnel Port_EVPN_XXX is not allowed (PR sonic-net#3402) Tunnel ports are always tagged and can't be created as untagged. But the code currently tries to set a pvid on a tunnel which is disallowed leading to an error in the logs. This is a simple fix to get rid of the error in the logs. It does not actually change behavior in any way other than getting rid of an error thus helping debugability. Signed-off-by: Brad House (@bradh352)
srj102
reviewed
Jan 10, 2025
| @@ -2410,7 +2410,7 @@ bool EvpnRemoteVnip2pOrch::addOperation(const Request& request) | |||
|
|
|||
| // SAI Call to add tunnel to the VLAN flood domain | |||
|
|
|||
| string tagging_mode = "untagged"; | |||
There was a problem hiding this comment.
While I agree that tagged may be a more appropriate setting for tunnels,
Many SAI implementations would have already been done with untagged mode for tunnels.
So I am not sure about the implications across all the silicons.
If the only issue is the ERROR log - can we not change this to an INFO log in setPortPvid ?
There was a problem hiding this comment.
You're right that it ends up sending SAI_VLAN_MEMBER_ATTR_VLAN_TAGGING_MODE as SAI_VLAN_TAGGING_MODE_TAGGED to the SAI rather than what it used to of SAI_VLAN_TAGGING_MODE_UNTAGGED. Obviously it also bypasses the call to setPortPvid() as well which is the main intention.
Setting tagging mode of untagged seems really wrong though, and could see it causing all sorts of issues with new silicon in the future trying to somehow honor that. Of course I only have Broadcom Trident 3 to actually test this with, but I'd be surprised if it is meaningful to any current asic.
But if you really want, I can just check if the port type is a tunnel here and bypass calling setPortPvid(), I don't think it makes sense to output the log entry about this at all regardless of the level. Let me know how to proceed.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 11, 2025
… tunnel Port_EVPN_XXX is not allowed (PR sonic-net#3402) Tunnel ports are always tagged and can't be created as untagged. But the code currently tries to set a pvid on a tunnel which is disallowed leading to an error in the logs. This is a simple fix to get rid of the error in the logs. It does not actually change behavior in any way other than getting rid of an error thus helping debugability. Signed-off-by: Brad House (@bradh352)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Tunnel ports are always considered tagged and we can't create an untagged/pvid vlan. But the code currently tries to set a pvid on a tunnel which is disallowed leading to an error in the logs.
This is a simple fix to get rid of the error in the logs. It does not actually change behavior in any way other than getting rid of an error thus helping debugability.
Why I did it
To get rid of confusing log message:
How I verified it
Applied patch, notice error no longer printed in logs.
Details if related
Signed-off-by: Brad House (@bradh352)