[orchagent] Do not restore port admin if port admin is configured #3447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@PJHsieh , do you've some logs and examples of the issue you are fixing in this PR? |
Hi, @prsunny , please check the following flow. Example: User set port FEC: User set port admin: |
Issue: The pCfg.admin_status might be overridden by prior configurations. Solution: Only restore port admin if port admin is not configured.
PJHsieh
force-pushed
the
restore_port_admin_only_if_not_configured
branch
from
eba4d4b to
3d57dd8
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Only restore port admin if port admin is not configured.
Why I did it
The pCfg.admin_status might be overridden by prior configurations.
How I verified it
Details if related