fix reduplicated predecessors problem

soot-oss · Dec 20, 2024 · 9de327e · 9de327e
1 parent 1a33bc3
commit 9de327e
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 18 deletions.
diff --git a/shared-test-resources/bugfixes/TrapSSA.class b/shared-test-resources/bugfixes/TrapSSA.class
diff --git a/sootup.core/src/main/java/sootup/core/graph/MutableBlockStmtGraph.java b/sootup.core/src/main/java/sootup/core/graph/MutableBlockStmtGraph.java
@@ -1369,8 +1369,8 @@ protected void putEdge_internal(@Nonnull Stmt stmtA, int succesorIdx, @Nonnull S
                 .values()
                 .forEach(
                     eb -> {
+                      // blockA is in eb's predecessors list, because A and B have same ebs.
                       eb.removePredecessorBlock(blockB);
-                      eb.addPredecessorBlock(blockA);
                     });
 
           } else {

diff --git a/sootup.tests/src/test/java/sootup/tests/InsertBeforeAfterTest.java b/sootup.tests/src/test/java/sootup/tests/InsertBeforeAfterTest.java
@@ -18,7 +18,6 @@
 import sootup.core.model.SourceType;
 import sootup.core.signatures.MethodSignature;
 import sootup.core.types.ClassType;
-import sootup.core.util.DotExporter;
 import sootup.java.bytecode.frontend.inputlocation.PathBasedAnalysisInputLocation;
 import sootup.java.core.JavaIdentifierFactory;
 import sootup.java.core.language.JavaJimple;
@@ -668,20 +667,4 @@ public void testInsertAfterBlockMiddle2() {
             + "}\n";
     Assertions.assertEquals(exceptedBody, builder.build().toString());
   }
-
-  @Test
-  public void testErrors() {
-    ClassType clazzType = factory.getClassType("TrapSSA");
-    MethodSignature methodSignature =
-        factory.getMethodSignature(
-            clazzType, "main", "void", Collections.singletonList("java.lang.String[]"));
-    final Path path = Paths.get(location + "TrapSSA.class");
-    PathBasedAnalysisInputLocation inputLocation =
-        new PathBasedAnalysisInputLocation.ClassFileBasedAnalysisInputLocation(
-            path, "", SourceType.Application);
-    JavaView view = new JavaView(inputLocation);
-    Body body = view.getMethod(methodSignature).get().getBody();
-    System.out.println(DotExporter.createUrlToWebeditor(body.getStmtGraph()));
-    System.out.println(body);
-  }
 }