incorporate PR feedback

soot-oss · Jan 31, 2024 · f139b8e · f139b8e
1 parent 66a0cc8
commit f139b8e
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 9 deletions.
diff --git a/sootup.core/src/main/java/sootup/core/IdentifierFactory.java b/sootup.core/src/main/java/sootup/core/IdentifierFactory.java
@@ -246,7 +246,9 @@ FieldSignature getFieldSignature(
 
   boolean isStaticInitializerSubSignature(@Nonnull MethodSubSignature methodSubSignature);
 
-  boolean isConstructorSubSignature(@Nonnull MethodSignature methodSignature);
+  boolean isConstructorSignature(@Nonnull MethodSignature methodSignature);
+
+  boolean isConstructorSubSignature(@Nonnull MethodSubSignature methodSubSignature);
 
   boolean isMainSubSignature(@Nonnull MethodSubSignature methodSubSignature);
 }
diff --git a/sootup.java.bytecode/src/test/java/sootup/java/bytecode/frontend/AsmMethodSourceTest.java b/sootup.java.bytecode/src/test/java/sootup/java/bytecode/frontend/AsmMethodSourceTest.java
@@ -39,7 +39,8 @@ public void testFix_StackUnderrun_convertPutFieldInsn_init() {
             Arrays.asList(
                 "java.util.concurrent.Executor", "javax.management.MBeanNotificationInfo[]"));
 
-    assertTrue(idf.isConstructorSubSignature(mainMethodSignature));
+    assertTrue(idf.isConstructorSignature(mainMethodSignature));
+    assertTrue(idf.isConstructorSubSignature(mainMethodSignature.getSubSignature()));
 
     final SootClass abstractClass = view.getClass(mainClassSignature).get();
 

diff --git a/sootup.java.core/src/main/java/sootup/java/core/JavaIdentifierFactory.java b/sootup.java.core/src/main/java/sootup/java/core/JavaIdentifierFactory.java
@@ -55,20 +55,23 @@ public class JavaIdentifierFactory implements IdentifierFactory {
   @Nonnull private static final JavaIdentifierFactory INSTANCE = new JavaIdentifierFactory();
 
   @Nonnull
-  public final MethodSubSignature STATIC_INITIALIZER =
+  public static final MethodSubSignature STATIC_INITIALIZER =
       new MethodSubSignature("<clinit>", Collections.emptyList(), VoidType.getInstance());
 
   @Override
   public boolean isStaticInitializerSubSignature(@Nonnull MethodSubSignature methodSubSignature) {
-    return methodSubSignature.getName().equals("<clinit>")
-        && methodSubSignature.getParameterTypes().isEmpty()
-        && methodSubSignature.getType() == VoidType.getInstance();
+    return methodSubSignature.equals(STATIC_INITIALIZER);
   }
 
   @Override
-  public boolean isConstructorSubSignature(@Nonnull MethodSignature methodSignature) {
-    return methodSignature.getName().equals("<init>")
-        && methodSignature.getType() == VoidType.getInstance();
+  public boolean isConstructorSignature(@Nonnull MethodSignature methodSignature) {
+    return isConstructorSubSignature(methodSignature.getSubSignature());
+  }
+
+  @Override
+  public boolean isConstructorSubSignature(@Nonnull MethodSubSignature methodSubSignature) {
+    return methodSubSignature.getName().equals("<init>")
+        && methodSubSignature.getType() == VoidType.getInstance();
   }
 
   @Override