-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactored pom dependencies for #1012 #1018
refactored pom dependencies for #1012 #1018
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Hi @swissiety, is there anything I can address or improve to help get this pull request accepted? |
Hi, |
Hi @swissiety |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1018 +/- ##
=============================================
+ Coverage 70.24% 71.96% +1.71%
- Complexity 4199 4453 +254
=============================================
Files 316 367 +51
Lines 15748 16389 +641
Branches 2699 2745 +46
=============================================
+ Hits 11062 11794 +732
+ Misses 3812 3689 -123
- Partials 874 906 +32 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
refactored pom dependencies
<version>${project.version}</version>
in every submodule pom<dependencyManagement>
block to the central POM file and included the module dependencies with<version>${project.version}</version>
within it.opened for the first task of #1012