fix bug in removeDefLocalsOf, also lp issue #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cannot-invoke-sootupcorejimplebasiclocalgetname-because-newlocal-is-null
stschott
requested changes
Oct 23, 2024
…cannot-invoke-sootupcorejimplebasiclocalgetname-because-newlocal-is-null
stschott
reviewed
Oct 25, 2024
| List<Stmt> localOccurrences = new ArrayList<>(); | ||
| for (Stmt stmt : stmts) { | ||
| if (stmt.equivTo(removedStmt)) continue; | ||
| List<Value> stmtUses = stmt.getUsesAndDefs().collect(Collectors.toList()); |
There was a problem hiding this comment.
Do you really want stmt.getUsesAndDefs()? Shouldn't it be stmt.getUses()?
There was a problem hiding this comment.
getUses only gives me only the right hand side values like b = virtualinvoke(a) but stmt.getUsesAndDefs() also gives me a = anything i.e definitions of a.
There was a problem hiding this comment.
If it's the uses AND defs that you want then we should rename this method/variables.
…cannot-invoke-sootupcorejimplebasiclocalgetname-because-newlocal-is-null
depscan
approved these changes
Oct 30, 2024
depscan
approved these changes
Oct 30, 2024
depscan
approved these changes
Oct 30, 2024
stschott
approved these changes
Oct 30, 2024
stschott
deleted the
1095-bug-nullpointerexception-cannot-invoke-sootupcorejimplebasiclocalgetname-because-newlocal-is-null
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.