-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
not throw exceptions when class of annotation not found #726
not throw exceptions when class of annotation not found #726
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #726 +/- ##
=============================================
- Coverage 63.95% 63.68% -0.28%
+ Complexity 3424 3342 -82
=============================================
Files 317 317
Lines 15391 15071 -320
Branches 2609 2542 -67
=============================================
- Hits 9844 9598 -246
+ Misses 4639 4588 -51
+ Partials 908 885 -23 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the small fix. Could you add a warning showing the missing annotation. So User will know that SootUp might need more data.
sootup.java.core/src/main/java/sootup/java/core/types/AnnotationType.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
When analysing single jar package, Sootup throws exceptions when some class of the annotation is missing.
In this PR:
getAnnotations
sincegetDefaultValues
is called inresolveDefaultsForAnnotationType
.getAnnotations
without the default values.