fix ConcurrentModificationException when calling SootClass.getMethods…

…ByNameAndParamCount bug
soot-oss · Jan 17, 2024 · 4056d91 · 4056d91
1 parent 395b878
commit 4056d91
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/main/java/soot/SootClass.java b/src/main/java/soot/SootClass.java
@@ -1304,12 +1304,14 @@ public boolean isOpenedByModule() {
    */
   public Collection<SootMethod> getMethodsByNameAndParamCount(String name, int paramCount) {
     List<SootMethod> result = null;
-    for (SootMethod m : getMethods()) {
-      if (m.getParameterCount() == paramCount && m.getName().equals(name)) {
-        if (result == null) {
-          result = new ArrayList<>();
+    synchronized(this) {
+      for (SootMethod m : getMethods()) {
+        if (m.getParameterCount() == paramCount && m.getName().equals(name)) {
+          if (result == null) {
+            result = new ArrayList<>();
+          }
+          result.add(m);
         }
-        result.add(m);
       }
     }