Hotfix/json decode error on optional str fields #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Models with optional string fields were raising
orjson.JSONDecodeError
errors.Cause
The parser was attempting to parse non-JSON string like 'hi' instead of strings like '"hi"' or '{"foo": "bar"}'.
This would occur when the optional string fields actually had strings in them.
Remedy
Filter out any fields that are of type
str
orOptional[str]
orstr | None
and avoid JSON-parsing their values in case their values are strings.Thanks to @nmarusov for discovering this issue and doing the initial fixes.