Fix: update_acl_rule() fixes (#75)

sophos · Aug 9, 2024 · a17f4fd · a17f4fd
1 parent 47858af
commit a17f4fd
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -3,7 +3,7 @@ name = "sophosfirewall-python"
 packages = [
     { include = "sophosfirewall_python" },
 ]
-version = "0.1.45"
+version = "0.1.46"
 description = "Python SDK for Sophos Firewall"
 authors = ["Matt Mullen <[email protected]>"]
 readme = "README.md"

diff --git a/sophosfirewall_python/admin.py b/sophosfirewall_python/admin.py
@@ -130,9 +130,9 @@ def update(self, name, description, source_zone, source_list, dest_list, service
                 "name": name,
                 "description": description,
                 "source_zone": source_zone,
-                "source_list": source_list,
-                "dest_list": dest_list,
-                "service_list": service_list,
+                "source_list": source_list if source_list else exist_sources,
+                "dest_list": dest_list if dest_list else exist_dests,
+                "service_list": service_list if service_list else exist_services,
                 "action": action
             }
         elif update_action == "remove":

diff --git a/sophosfirewall_python/templates/updateserviceacl.j2 b/sophosfirewall_python/templates/updateserviceacl.j2
@@ -21,11 +21,13 @@
                 {% endif %}
 			</Hosts>
 			{% endif %}
+			{% if service_list %}
 			<Services>
 				{% for service in service_list %}
 				<Service>{{ service }}</Service>
 				{% endfor %}
 			</Services>
+			{% endif %}
 			<Action>{{ action | lower }}</Action>
 		</LocalServiceACL>
    </Set>