Merge pull request #218 from toneill818/main

fix: Correct extraEnv values for Director and Dashboard
sorry-cypress · Jun 11, 2023 · b10f603 · b10f603
2 parents fc6fbbf + 24e379f
commit b10f603
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/charts/sorry-cypress/Chart.yaml b/charts/sorry-cypress/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: sorry-cypress
 description: A Helm chart for Sorry Cypress
 type: application
-version: 1.13.2
+version: 1.13.3
 appVersion: 2.5.3
 home: https://sorry-cypress.dev/
 sources:

diff --git a/charts/sorry-cypress/changelog.md b/charts/sorry-cypress/changelog.md
@@ -1,6 +1,9 @@
 # 1.14
 - Update app to version `2.5.3`
 
+# 1.13.3
+- Fixed extra environment variables for director and dashboard deployments
+
 # 1.13.2
 - Add option to include addional environment variables for the director, dashboard and api containers
 

diff --git a/charts/sorry-cypress/templates/deployment-dashboard.yml b/charts/sorry-cypress/templates/deployment-dashboard.yml
@@ -55,7 +55,7 @@ spec:
         {{- end }}
         - name: PORT
           value: "{{ .Values.dashboard.service.port }}"
-        {{- with .Values.api.extraEnv }}
+        {{- with .Values.dashboard.extraEnv }}
         {{- toYaml . | nindent 8 }}
         {{- end }}
         image: "{{ .Values.dashboard.image.repository }}:{{ .Values.dashboard.image.tag | default .Chart.AppVersion }}"

diff --git a/charts/sorry-cypress/templates/deployment-director.yml b/charts/sorry-cypress/templates/deployment-director.yml
@@ -161,7 +161,7 @@ spec:
           value: {{ .Values.director.environmentVariables.inactivityTimeoutSeconds | quote }}
         - name: GITLAB_JOB_RETRIES
           value: {{ .Values.director.environmentVariables.gitlabJobRetries | quote }}
-        {{- with .Values.api.extraEnv }}
+        {{- with .Values.director.extraEnv }}
         {{- toYaml . | nindent 8 }}
         {{- end }}
         image: "{{ .Values.director.image.repository }}:{{ .Values.director.image.tag | default .Chart.AppVersion }}"