[SG-33303-2] Upgrade to the latest version of typescript-eslint #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valerybugakov
requested changes
May 19, 2022
valerybugakov
requested changes
May 20, 2022
valerybugakov
requested changes
May 20, 2022
There was a problem hiding this comment.
Let's make final adjustments based on the comment #247 (comment), and it will be good to go!
valerybugakov
approved these changes
May 26, 2022
There was a problem hiding this comment.
Thank you! 🚀 Please follow Conventional Commit Messages format to trigger a new version release on the merge of this PR.
| '@typescript-eslint/no-unsafe-return': 'warn', | ||
| // Turned off this rule since it was throwing | ||
| // TypeError: Cannot read property 'kind' of undefined | ||
| '@typescript-eslint/no-unsafe-return': 'off', |
There was a problem hiding this comment.
@gitstart-sourcegraph, could you please create an issue in the repo to fix this problem?
|
|
||
| '@typescript-eslint/no-unsafe-argument': 'off', | ||
| '@typescript-eslint/no-unnecessary-type-constraint': 'off', | ||
| // End |
There was a problem hiding this comment.
@gitstart-sourcegraph, could you please create an issue in the repo to review these newly added rules and enable them if we see fit?
|
🎉 This PR is included in version 0.30.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
Description
Our
typescript-eslintversion is outdated, and we need to upgrade to the latest one to use new features.Success Criteria
typescript-eslintis upgraded to the latest version.Implementation Details
Refs
Sourcegraph Issue
Gitstart Ticket
Related Issues
1
2