Skip to content

Commit

Permalink
Define field arguments in a deterministic order
Browse files Browse the repository at this point in the history
  • Loading branch information
AndrewSisley committed Jul 14, 2022
1 parent bc95f52 commit 11917e0
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions definition.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import (
"fmt"
"reflect"
"regexp"
"sort"
"strings"

"github.com/graphql-go/graphql/language/ast"
)
Expand Down Expand Up @@ -588,6 +590,12 @@ func defineFieldMap(ttype Named, fieldMap Fields) (FieldDefinitionMap, error) {
}
fieldDef.Args = append(fieldDef.Args, fieldArg)
}

// Sort args so that their order is deterministic (alpha-numeric descending)
sort.Slice(fieldDef.Args, func(i, j int) bool {
return strings.Compare(fieldDef.Args[i].Name(), fieldDef.Args[j].Name()) == -1
})

resultFieldMap[fieldName] = fieldDef
}
return resultFieldMap, nil
Expand Down

0 comments on commit 11917e0

Please sign in to comment.