Pass Watchdog token via environment variable #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are still hubbed servers (Dungeon Dig) that are using an engine version too old to support this. This is the reason I've been wary of doing this myself. I guess just pinging for the breaking change is probably fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27 .
Necessary as command line arguments, through which this was originally passed, show up in process listings on the host. Environment variables are generally the preferred way of passing secrets to processes.
RobustToolbox supports this syntax as of the 4th of April 2024 with commit 84360c653d26baa4ce7510d8d1b003ea617aa02b . This PR does form a breaking change for use cases where older versions of RobustToolbox are required, and this should be communicated accordingly if deemed relevant.