-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move lathe recipes into packs (easier for forks and maintaining) #33095
base: master
Are you sure you want to change the base?
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Really think the roundstart/balance changes need to be split off from this. I love the technical details of the PR and would instantly approve it, but the fact that there's balancing changes make it a bit more difficult to review. That and having to go through the list sucks on its own already. |
some of the changes like for ammofab would mean a lot of duplication |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor nits
Co-authored-by: pathetic meowmeow <[email protected]>
Co-authored-by: pathetic meowmeow <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
About the PR
packs are shared between lathes to:
ingame changes are below
Why / Balance
Technical details
Media
roundstart circuit printer
roundstart protolathe, has sci tools and more chem stuff
autolathe is still random shit
and has batong
valid uniform printer still prints centcomm and syndie clothes (which can now trivially be made normal recipes for a special centcomm or syndie printer prototype )
i would show research but funny interaction debug assert trolling
Requirements
Breaking changes
LatheComponent and EmagLatheComponent static/dynamic recipes have been replaced with a list of pack ids. (Static/DynamicRecipes -> Index(∑ Static/DynamicPacks).Recipes
if you are adding things to them instead of adding recipes to upstream packs make your own pack and either make an upstream pack inherit it, or add it to an upstream lathe's pack list
example below
Changelog
ingame changes are too minor for cl