-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ammunition box (.50), Liberation Station .50 stock #33515
base: master
Are you sure you want to change the base?
Conversation
@@ -47,7 +47,7 @@ | |||
- state: beanbag | |||
|
|||
- type: entity | |||
name: shell box (lethal) | |||
name: ammunition box (.50 pellet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in BaseMagazineShotgun
this is called (.50 shells)
Not sure which one is technically correct, but it should be consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's slightly complicated because .50 shells is a generic name, despite the fact we have .50 beanbags and .50 tranqs and so forth
I'm probably gonna rename all instances of .50 shells and ballistic ammo providers of .50 shells to pellets then
Depending on the response to #34284, I might rename all instances of ".50" to "12G" |
About the PR
Why / Balance
Shotgun ammo boxes now follow naming convetion of other ammo boxes. For example, "shell box (X)" is now "ammunition box (.50 X)." This means shotgun shell boxes will actually appear in the sec techfab when searching ammunition.
Added six .50 pellet boxes and three .50 practice boxes to the Liberation Vendor. Even if it's admeme or CC-only content, it's worth keeping inventory up to date.
Technical details
yml changes only
Resources/Prototypes/Catalog/VendingMachines/Inventories/ammo.yml
(added .50 pellet and practice rounds)Resources/Prototypes/Catalog/VendingMachines/Inventories/shotgun.yml
(renamed shotgun ammunition boxes)Media
Note: screenshot includes outdated 'buckshot' term, updated to 'pellet' by latest commit
Requirements
or it does not require an ingame showcase.Breaking changes
Changelog
🆑