Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ammunition box (.50), Liberation Station .50 stock #33515

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

K-Dynamic
Copy link
Contributor

@K-Dynamic K-Dynamic commented Nov 24, 2024

About the PR

  • Renames ammo boxes; "shell box (X)" to "ammunition box (.50 X)"
  • Adds .50 shells to Liberation Station vendor (six .50 pellet, three .50 practice)

Why / Balance

Shotgun ammo boxes now follow naming convetion of other ammo boxes. For example, "shell box (X)" is now "ammunition box (.50 X)." This means shotgun shell boxes will actually appear in the sec techfab when searching ammunition.

Added six .50 pellet boxes and three .50 practice boxes to the Liberation Vendor. Even if it's admeme or CC-only content, it's worth keeping inventory up to date.

Technical details

yml changes only

  • Resources/Prototypes/Catalog/VendingMachines/Inventories/ammo.yml (added .50 pellet and practice rounds)
  • Resources/Prototypes/Catalog/VendingMachines/Inventories/shotgun.yml (renamed shotgun ammunition boxes)

Media

image
Note: screenshot includes outdated 'buckshot' term, updated to 'pellet' by latest commit

Requirements

Breaking changes

Changelog

🆑

  • tweak: Renamed "shell box (X)" to "ammunition box (.50 X)" to match existing naming scheme, and are thus easier to find in certain vendors and fabricators.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. and removed size/S Denotes a PR that changes 10-99 lines. labels Nov 24, 2024
@ScarKy0 ScarKy0 added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 24, 2024
@@ -47,7 +47,7 @@
- state: beanbag

- type: entity
name: shell box (lethal)
name: ammunition box (.50 pellet)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in BaseMagazineShotgun this is called (.50 shells)
Not sure which one is technically correct, but it should be consistent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's slightly complicated because .50 shells is a generic name, despite the fact we have .50 beanbags and .50 tranqs and so forth

I'm probably gonna rename all instances of .50 shells and ballistic ammo providers of .50 shells to pellets then

@K-Dynamic
Copy link
Contributor Author

Depending on the response to #34284, I might rename all instances of ".50" to "12G"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants