Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor light mask prototypes for compatibility with illumination measuring system of RobustToolbox #34056

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Chubbygummibear
Copy link
Contributor

@Chubbygummibear Chubbygummibear commented Dec 24, 2024

About the PR

light masks for PointLightComponents are expanded to be their own prototype so that in addition to the texture which will be applied to the light, the specifications of those cones, such as angle of light being cast, and the number of cones, is stored in that prototype. This is so that while the client overlays the texture for rendering, the server has usable data for calculating exposure to those lights which would otherwise be treated as a full circle, rather than a cone.

Why / Balance

The LightSensitiveSystem I created for RobustToolbox needs usable numbers in the form of light cone specifics to accompany textures, because the server can't utilize a texture for calculating what entities are and aren't in a light cone being pointed around the game world.

Important to note that the data which accompanies each texture is still eyeballed by me. So if it feels like maybe you're in or out of the light and not getting the right exposure level, it's because there's no way to actually read in the texture to the server to get an exact shape for it 😔

Technical details

Requires space-wizards/RobustToolbox#5574

Media

2024-12-24.14-03-19.mp4
2024-12-23.14-05-53.mp4

Requirements

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines. labels Dec 24, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-99 lines. label Dec 24, 2024
@ScarKy0 ScarKy0 added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Engine PR Merged Status: Requires an existing Robust Toolbox PR to be merged first. T: Cleanup Type: Code clean-up, without being a full refactor or feature D3: Low Difficulty: Some codebase knowledge required. A: Core Tech Area: Underlying core tech for the game and the Github repository. S: Needs Review Status: Requires additional reviews before being fully accepted labels Dec 24, 2024
@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Engine PR Merged Status: Requires an existing Robust Toolbox PR to be merged first. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants