-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cyborg Rebalance #34186
base: master
Are you sure you want to change the base?
Cyborg Rebalance #34186
Conversation
This PR contains new or changed maps:
Maps are being rendered. This comment will be updated if rendering them is done. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
I feel like a complete overhaul/rebalance like this would only be appropriate when we get an alternative or better version of round removal recovery (like cloning). |
Yeah let's just keep every Cyborg in a dogshit state for the next months or maybe even years for literally no reason. This is a good rebalance and its absolutely needed for every Cyborg chassis except Engineer. Engineer only needs a holofan at this point. As for the PR itself I don't think removing the RCD from round start is necessary. It isn't as broken as people think because of how slow it recharges. |
I was pointing to how borging shouldn't be super glamorized or incentivised, and how expensive they would be to produce. Borging is only as common as it is currently because we lack any other ways to bring people back into the round and ideally it would be reserved as a last resort, where people volunteer for its very niche benefits or as punishment I think giving every Borg the tools module is a good addition though, shouldn't have been removed in the first place |
I don't mind most of the actual module changes outside of the custodial module, but it's the price changes mainly that I think will be a massive pain. And some of these buffs may need to be reeled back in the future when other RR recovery methods become available (not telling you not to, just an observation). Also give service Borg some love!!!! |
I'm not exactly against it since the other changes are good regardless for borgs, but why remove the RCD module? I really don't think it's OP like everyone makes it out to be. You already have to wait a while for it to recharge compared to engineers just buying more matter packs from cargo whenever they want. In SS13 iirc the recharge is based around the cyborg's battery. If you want to nerf it, you could maybe do that instead. Or just make it require matter compressors. Either way it shouldn't be worse than a normal engineer imo. Great changes otherwise though. Always seemed kind of silly that mediborgs didn't have a defib module, I'm guessing it was an oversight.
I mean people also enjoy playing borgs roundstart. It would be nice to at least get the bare necessities like a defib module for medborgs. |
Duplicate intent of #33748
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some concerns I had with the distribution of some items, plus some minor YAML things.
Resources/Prototypes/Entities/Objects/Specific/Janitorial/trashbag.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Objects/Specific/Janitorial/trashbag.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Objects/Specific/Janitorial/trashbag.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Objects/Specific/Janitorial/trashbag.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Objects/Specific/Janitorial/spray.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Objects/Specific/Janitorial/spray.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Objects/Specific/Janitorial/spray.yml
Outdated
Show resolved
Hide resolved
…hbag.yml Co-authored-by: ArtisticRoomba <[email protected]>
This PR contains new or changed maps:
Maps are being rendered. This comment will be updated if rendering them is done. |
…y.yml Co-authored-by: ArtisticRoomba <[email protected]>
This PR contains new or changed maps:
Maps are being rendered. This comment will be updated if rendering them is done. |
…hbag.yml Co-authored-by: ArtisticRoomba <[email protected]>
This PR contains new or changed maps:
Maps are being rendered. This comment will be updated if rendering them is done. |
@Djungelskog2 what do you dislike about the custodial module? my aim was to reduce X key spam by spreading the tools throughout two modules instead of jamming all but one of them into the cleaning module. |
how did this sneak in
This PR contains new or changed maps:
Maps are being rendered. This comment will be updated if rendering them is done. |
no more superbag.
This PR contains new or changed maps:
Maps are being rendered. This comment will be updated if rendering them is done. |
okay finally ready for merging. |
you need to update your PR comment and fix your CL, and the sprites need changing |
just waiting on the sprites from Roomba.... |
RSI Diff Bot; head commit 799a363 merging into 0707ee5 Resources/Textures/Interface/Actions/actions_borg.rsi
Resources/Textures/Objects/Specific/Robotics/borgmodule.rsi
|
all ready to go. |
i'll review later, but you'll want to fix your CL so people are properly attributed in the CL: 🆑 Nox38, Venikt, ArtisticRoomba |
Oh, so thats where you put attributions. Done. |
meta.json files should properly attribute their creators as well, scarky0 forgot to attribute themselves in their PR which added the module actions to begin with , so just smack scarky's name in their along with mine, preferably stating who made what. if i remember correctly the state-laws icon is from TG and so is the select-type one. so just say the module action icons were made by scarky0 and link their PR in the attributions (#32505), put my name in there saying i made the three used in this PR, linking it as well. also be sure to use my github name rather than my discord one, venikt is not my github username or my in-game one, so list it as it is on here to avoid any confusion (muburu_). |
Resources/Prototypes/Entities/Objects/Specific/Salvage/ore_bag.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Objects/Specific/Salvage/ore_bag.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Objects/Specific/Salvage/ore_bag.yml
Outdated
Show resolved
Hide resolved
All suggestions implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some unaddressed YAML stuff plus nitpicks, otherwise looks all good.
Resources/Prototypes/Entities/Objects/Specific/Salvage/ore_bag.yml
Outdated
Show resolved
Hide resolved
Resources/Textures/Interface/Actions/actions_borg.rsi/meta.json
Outdated
Show resolved
Hide resolved
….yml Co-authored-by: ArtisticRoomba <[email protected]>
Co-authored-by: ArtisticRoomba <[email protected]>
About the PR
Changes the content of each module and the modules gained on roundstart for balance.
Why / Balance
Stations only feature 2-4 cyborg spawn points at round start, and they are otherwise expensive to make and very specialized, so it is fair to assume that they should reliably do their jobs better than an organic. Some cyborgs had overpowered modules and some had underpowered modules, this aims to make them all fun to use and fair.
Technical details
Changed the default starting modules and the content of each module.
Media
Requirements
Breaking changes
Changelog
🆑 Nox38, ArtisticRoomba