Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyborg Rebalance #34186

Open
wants to merge 52 commits into
base: master
Choose a base branch
from
Open

Cyborg Rebalance #34186

wants to merge 52 commits into from

Conversation

Nox38
Copy link
Contributor

@Nox38 Nox38 commented Jan 2, 2025

About the PR

Changes the content of each module and the modules gained on roundstart for balance.

Why / Balance

Stations only feature 2-4 cyborg spawn points at round start, and they are otherwise expensive to make and very specialized, so it is fair to assume that they should reliably do their jobs better than an organic. Some cyborgs had overpowered modules and some had underpowered modules, this aims to make them all fun to use and fair.

Technical details

Changed the default starting modules and the content of each module.

Media

image

Requirements

Breaking changes

Changelog
🆑 Nox38, ArtisticRoomba

  • Tweak: Rebalanced cyborg modules and made more of them starting equipment.
  • Add: Added new advanced mining and advanced chemical modules.

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • meta.yml

Maps are being rendered. This comment will be updated if rendering them is done.
01/02/25 22:58

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Map Changes: Might require knowledge of mapping. size/XL Denotes a PR that changes 5000+ lines. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Djungelskog2
Copy link

I feel like a complete overhaul/rebalance like this would only be appropriate when we get an alternative or better version of round removal recovery (like cloning).

@SlimmSlamm
Copy link
Contributor

I feel like a complete overhaul/rebalance like this would only be appropriate when we get an alternative or better version of round removal recovery (like cloning).

Yeah let's just keep every Cyborg in a dogshit state for the next months or maybe even years for literally no reason. This is a good rebalance and its absolutely needed for every Cyborg chassis except Engineer. Engineer only needs a holofan at this point.

As for the PR itself I don't think removing the RCD from round start is necessary. It isn't as broken as people think because of how slow it recharges.

@Djungelskog2
Copy link

I feel like a complete overhaul/rebalance like this would only be appropriate when we get an alternative or better version of round removal recovery (like cloning).

Yeah let's just keep every Cyborg in a dogshit state for the next months or maybe even years for literally no reason. This is a good rebalance and its absolutely needed for every Cyborg chassis except Engineer. Engineer only needs a holofan at this point.

As for the PR itself I don't think removing the RCD from round start is necessary. It isn't as broken as people think because of how slow it recharges.

I was pointing to how borging shouldn't be super glamorized or incentivised, and how expensive they would be to produce. Borging is only as common as it is currently because we lack any other ways to bring people back into the round and ideally it would be reserved as a last resort, where people volunteer for its very niche benefits or as punishment

I think giving every Borg the tools module is a good addition though, shouldn't have been removed in the first place

@Djungelskog2
Copy link

I don't mind most of the actual module changes outside of the custodial module, but it's the price changes mainly that I think will be a massive pain. And some of these buffs may need to be reeled back in the future when other RR recovery methods become available (not telling you not to, just an observation). Also give service Borg some love!!!!

@Chubbicous
Copy link
Contributor

Chubbicous commented Jan 3, 2025

I'm not exactly against it since the other changes are good regardless for borgs, but why remove the RCD module? I really don't think it's OP like everyone makes it out to be. You already have to wait a while for it to recharge compared to engineers just buying more matter packs from cargo whenever they want. In SS13 iirc the recharge is based around the cyborg's battery. If you want to nerf it, you could maybe do that instead. Or just make it require matter compressors. Either way it shouldn't be worse than a normal engineer imo.

Great changes otherwise though. Always seemed kind of silly that mediborgs didn't have a defib module, I'm guessing it was an oversight.

I feel like a complete overhaul/rebalance like this would only be appropriate when we get an alternative or better version of round removal recovery (like cloning).

I mean people also enjoy playing borgs roundstart. It would be nice to at least get the bare necessities like a defib module for medborgs.

@ArtisticRoomba
Copy link
Contributor

ArtisticRoomba commented Jan 3, 2025

Construction module: Added plasteel and reinforced glass!

Duplicate intent of #33748

Advanced Tools module: Removed remote signaler.

Any reason why? After reviewing I see why.

Copy link
Contributor

@ArtisticRoomba ArtisticRoomba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some concerns I had with the distribution of some items, plus some minor YAML things.

Resources/Maps/meta.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Maps/meta.yml Outdated Show resolved Hide resolved
@ss14-map-server
Copy link

This PR contains new or changed maps:

  • meta.yml

Maps are being rendered. This comment will be updated if rendering them is done.
01/03/25 21:13

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • meta.yml

Maps are being rendered. This comment will be updated if rendering them is done.
01/03/25 21:14

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • meta.yml

Maps are being rendered. This comment will be updated if rendering them is done.
01/03/25 21:16

@Nox38
Copy link
Contributor Author

Nox38 commented Jan 3, 2025

@Djungelskog2 what do you dislike about the custodial module? my aim was to reduce X key spam by spreading the tools throughout two modules instead of jamming all but one of them into the cleaning module.

how did this sneak in
@ss14-map-server
Copy link

This PR contains new or changed maps:

  • meta.yml

Maps are being rendered. This comment will be updated if rendering them is done.
01/03/25 21:38

no more superbag.
@ss14-map-server
Copy link

This PR contains new or changed maps:

  • meta.yml

Maps are being rendered. This comment will be updated if rendering them is done.
01/03/25 21:39

@Nox38
Copy link
Contributor Author

Nox38 commented Jan 6, 2025

okay finally ready for merging.

@ArtisticRoomba
Copy link
Contributor

you need to update your PR comment and fix your CL, and the sprites need changing

@Nox38
Copy link
Contributor Author

Nox38 commented Jan 9, 2025

just waiting on the sprites from Roomba....

@github-actions github-actions bot added the Changes: Sprites Changes: Might require knowledge of spriting or visual design. label Jan 9, 2025
@Nox38 Nox38 requested a review from deltanedas January 9, 2025 21:25
Copy link
Contributor

github-actions bot commented Jan 9, 2025

RSI Diff Bot; head commit 799a363 merging into 0707ee5
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Interface/Actions/actions_borg.rsi

State Old New Status
adv-chem-module Added
adv-mining-module Added
chem-module Added

Resources/Textures/Objects/Specific/Robotics/borgmodule.rsi

State Old New Status
icon-chem Added
icon-mining-adv Added

Edit: diff updated after 799a363

@Nox38 Nox38 requested a review from ArtisticRoomba January 9, 2025 21:25
@Nox38
Copy link
Contributor Author

Nox38 commented Jan 12, 2025

all ready to go.

@ArtisticRoomba
Copy link
Contributor

i'll review later, but you'll want to fix your CL so people are properly attributed in the CL:

🆑 Nox38, Venikt, ArtisticRoomba

@Nox38
Copy link
Contributor Author

Nox38 commented Jan 13, 2025

🆑 Nox38, Venikt, ArtisticRoomba

Oh, so thats where you put attributions. Done.

@muburu
Copy link
Contributor

muburu commented Jan 13, 2025

meta.json files should properly attribute their creators as well, scarky0 forgot to attribute themselves in their PR which added the module actions to begin with :trollface:, so just smack scarky's name in their along with mine, preferably stating who made what.

if i remember correctly the state-laws icon is from TG and so is the select-type one. so just say the module action icons were made by scarky0 and link their PR in the attributions (#32505), put my name in there saying i made the three used in this PR, linking it as well.

also be sure to use my github name rather than my discord one, venikt is not my github username or my in-game one, so list it as it is on here to avoid any confusion (muburu_).

@Nox38
Copy link
Contributor Author

Nox38 commented Jan 13, 2025

All suggestions implemented.

Copy link
Contributor

@ArtisticRoomba ArtisticRoomba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some unaddressed YAML stuff plus nitpicks, otherwise looks all good.

@Emisse Emisse removed the Changes: Map Changes: Might require knowledge of mapping. label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. D2: Medium Difficulty: A good amount of codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.