-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow paper labels on seeds #34450
base: master
Are you sure you want to change the base?
allow paper labels on seeds #34450
Conversation
Great idea! Test fail is real though, I think you need to add an ItemSlots component on the seeds themselves so it doesn't automatically add it when its spawned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine in game, love the idea!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good!
But could you change the changelog to something along the lines of "Seeds can now have paper labels attached to them"? I feel like the current one might be confused with the labeller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah tested works great! The only actual change I think is important is to make the label appear on the item itself (Like lockers see this pr #33318). It shouldn't be too hard but if you need help ask here or the discord 🫡
Resources/Prototypes/Entities/Objects/Specific/Hydroponics/seeds.yml
Outdated
Show resolved
Hide resolved
You'll need a new sprite for the labels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK tested and everything looks good! The only issue is that when you plant seeds with a tag, the tag is just deleted. Is that intended (I think its OK if it is, just wanted to make sure)?
It should probably drop. (Here is a little feature I imagine it being useful for: "Alien" seeds, when you find em they have a label attached with growing conditions (high/low pressure/temperate, specific gasses it needs) so it does not instantly die). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not using an event is a little sussy but I think its fine 🤔
I don't think there would be many other checks for a system like this
(Just waiting on art approval now)
I did not find a way to use All the ways I found required the seeds to be destructible or breakable (which they are not). |
Yeah you'd probably have to make a new event and stuff which seems like a lot of work for something that wont be used anywhere else! |
About the PR
This PR add the ability to add a paper label to seeds.
Why / Balance
Technical details
Media
Requirements
Breaking changes
None
Changelog
🆑