-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Void's Applause #34591
base: master
Are you sure you want to change the base?
Void's Applause #34591
Conversation
… replace pointlight with a negative light in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I cannot hear the single clap emote sound in-game.
Edit: Figured it out, lizards using the single clap emote does not make a sound, but for humans it does.
{ | ||
base.OnVoidApplause(ev); | ||
|
||
_chat.TryEmoteWithChat(ev.Performer, ev.Emote); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could probably be more generalized so it can be reused for other spells, similar to SpeakSpellEvent
.
One could even go one step further and have both speaking and emoting be supported for actions in general, maybe as component added to the action entity. This could also be used for the rat kings orders to his minions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im going to save that for when I (eventually) expand actions again and that'll be sometime after Wizard's release.
Co-authored-by: slarticodefast <[email protected]>
Co-authored-by: slarticodefast <[email protected]>
Co-authored-by: slarticodefast <[email protected]>
Co-authored-by: slarticodefast <[email protected]>
Co-authored-by: slarticodefast <[email protected]>
About the PR
Added a new Wizard ability - Void's Applause
Allows you to swap targets with the selected entity.
Comes with a fancy animation and a new emote - ClapSingle
Why / Balance
https://www.youtube.com/watch?v=v-CpYSTDbek
It's a fundamentally cool spell and helps fill out the Wizard catalog.
Technical details
ClapSingle emote & localization was added so this can be used effectively.
VoidApplauseSpellEvent was added to handle swapping the targets, speech, and spawning the effect. Now there's logic in the Client.MagicSystem class.
Media
VoidApplause.mp4
Requirements
Breaking changes
Changelog