Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Void's Applause #34591

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Void's Applause #34591

wants to merge 14 commits into from

Conversation

keronshb
Copy link
Contributor

@keronshb keronshb commented Jan 22, 2025

About the PR

Added a new Wizard ability - Void's Applause
Allows you to swap targets with the selected entity.
Comes with a fancy animation and a new emote - ClapSingle

Why / Balance

https://www.youtube.com/watch?v=v-CpYSTDbek

It's a fundamentally cool spell and helps fill out the Wizard catalog.

Technical details

ClapSingle emote & localization was added so this can be used effectively.

VoidApplauseSpellEvent was added to handle swapping the targets, speech, and spawning the effect. Now there's logic in the Client.MagicSystem class.

Media

VoidApplause.mp4

Requirements

Breaking changes

Changelog

@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: Sprites Changes: Might require knowledge of spriting or visual design. Changes: Audio Changes: Might require knowledge of audio. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 22, 2025
Copy link
Contributor

github-actions bot commented Jan 22, 2025

RSI Diff Bot; head commit e16e28e merging into b4fa49a
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Magic/Eldritch/eldritch_actions.rsi

State Old New Status
voidblink Added

Edit: diff updated after e16e28e

@slarticodefast
Copy link
Member

hq720

Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I cannot hear the single clap emote sound in-game.

Edit: Figured it out, lizards using the single clap emote does not make a sound, but for humans it does.

Content.Shared/Magic/SharedMagicSystem.cs Outdated Show resolved Hide resolved
@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D2: Medium Difficulty: A good amount of codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities labels Jan 23, 2025
@slarticodefast slarticodefast added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Jan 23, 2025
Content.Client/Magic/MagicSystem.cs Outdated Show resolved Hide resolved
{
base.OnVoidApplause(ev);

_chat.TryEmoteWithChat(ev.Performer, ev.Emote);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could probably be more generalized so it can be reused for other spells, similar to SpeakSpellEvent.
One could even go one step further and have both speaking and emoting be supported for actions in general, maybe as component added to the action entity. This could also be used for the rat kings orders to his minions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im going to save that for when I (eventually) expand actions again and that'll be sometime after Wizard's release.

Content.Shared/Magic/Events/VoidApplauseSpellEvent.cs Outdated Show resolved Hide resolved
Content.Shared/Magic/Events/VoidApplauseSpellEvent.cs Outdated Show resolved Hide resolved
Content.Client/Magic/MagicSystem.cs Show resolved Hide resolved
Resources/Audio/Effects/Emotes/attributions.yml Outdated Show resolved Hide resolved
Resources/Prototypes/SoundCollections/emotes.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities Changes: Audio Changes: Might require knowledge of audio. Changes: Sprites Changes: Might require knowledge of spriting or visual design. D2: Medium Difficulty: A good amount of codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Awaiting Changes Status: Changes are required before another review can happen size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants