Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return JSON from hare weight, total weight and beacon APIs #6627

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Jan 16, 2025

First part of #6623. Refactors:

  • /hare/total_weight/{layer}
  • /hare/weight/{node_id}/{layer}
  • /hare/beacon/{epoch}

@jellonek jellonek changed the title return JSON from hare weight,total weight and beacon APIs return JSON from hare weight, total weight and beacon APIs Jan 16, 2025
@poszu poszu merged commit e771d2e into node-split-poc Jan 16, 2025
13 checks passed
@poszu poszu deleted the node-split-api-return-json-part1 branch January 16, 2025 14:40
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 72.22222% with 20 lines in your changes missing coverage. Please review.

Please upload report for BASE (node-split-poc@837e7fa). Learn more about missing BASE report.
Report is 2 commits behind head on node-split-poc.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
api/node/client/client.gen.go 68.5% 8 Missing and 3 partials ⚠️
api/node/client/client.go 57.1% 9 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             node-split-poc   #6627   +/-   ##
================================================
  Coverage                  ?   77.7%           
================================================
  Files                     ?     376           
  Lines                     ?   51419           
  Branches                  ?       0           
================================================
  Hits                      ?   39992           
  Misses                    ?    9052           
  Partials                  ?    2375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants