Update NIRSpec anomaly flags

[stscijgbot-jwql]

Issue JWQL-155 was created on JIRA by Melanie Clarke:

NIRSpec would like to update the anomaly categories currently available, to better reflect which artifacts we’ve found useful to monitor.

The current categories are:

• Cosmic Ray Shower
• Diffraction Spike
• Excessive Saturation
• Guidestar Failure
• Persistence
• Crosstalk
• Data Transfer Error
• Ghost
• Snowball
• Dominant MSA Leakage
• Optical Short
• Other

We’d like to update them to:

• Unusual Cosmic Rays
• Unusual Snowballs
• Diffraction Spike
• Excessive Saturation
• Persistence
• Scattered Light
• Noticeable MSA Leakage
• New Short
• Transient Short
• Subsequently Masked Short
• Monitored Short
• Bright Object (not a short)
• Other
• Needs Discussion

With this mapping:

• Cosmic Ray Shower -> Unusual Cosmic Rays
• Diffraction Spike -> (keep)
• Excessive Saturation -> (keep)
• Guidestar Failure -> (remove)
• Persistence -> (keep)
• Crosstalk -> (remove)
• Data Transfer Error -> (remove)
• Ghost -> Scattered Light
• Snowball -> Unusual Snowballs
• Dominant MSA Leakage -> Noticeable MSA Leakage
• Optical Short -> New Short
• Other -> (keep)
• (add) -> Transient Short
• (add) -> Subsequently Masked Short
• (add) -> Monitored Short
• (add) -> Bright Object (not a short)
• (add) -> Needs Discussion

[stscijgbot-jwql]

Comment by Bryan Hilbert on JIRA:

Some questions came to mind as I began making these changes (in PR #⁠1418):

1. Cosmic ray showers -> Unusual cosmic rays: should we make this change for all NIR instruments, since the NIR detectors do not see cosmic ray showers?
2. Same question for Snowballs -> Unusual snowballs. ~All exposures contain snowballs, so in practice the teams are using this flag only for notable snowballs

[stscijgbot-jwql]

Comment by Bryan Hilbert on JIRA:

I've reached out to the NIRISS team about the two questions above. From a NIRCam perspective I think we would be fine with applying these changes to NIRCam as well as NIRSpec. If NIRISS is on board as well, that could help simplify things.

[stscijgbot-jwql]

Comment by Bryan Hilbert on JIRA:

NIRISS agrees that changing the names of the anomalies above is fine. NIRCam agrees as well. So I think it's safe to do this renaming for all NIR instruments, which will keep them all consistent.

[stscijgbot-jwql]

Comment by Bradley Sappington on JIRA:

Renaming will be for all instruments.  
Adding and subtracting will be for Nirspec only.  Correct?

[stscijgbot-jwql]

Comment by Bradley Sappington on JIRA:

conversation with Bryan Hilbert :

• Cosmic Ray Shower - keep as is for miri, remove option from other instruments
• Unusual Cosmic Rays - create this for all non miri instruments, migrate existing cosmic ray shower values here
• Ghost -> Scattered Light  re-name for all instruments (pending okay from miri and niriss)
• Snowball -> Unusual Snowballs  - rename for all instruments
• Dominant MSA Leakage -> Noticeable MSA Leakage  rename for all instruments
• Optical Short -> New Short  rename for all instruments

[stscijgbot-jwql]

Comment by Bradley Sappington on JIRA:

#1435