Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: Update NIRSpec anomaly list #1418

Closed

Conversation

bhilbert4
Copy link
Collaborator

Resolves #1410

Update the anomaly list for NIRSpec based on a new list provided by the team.

See #1410 or the associated JIRA ticket for discussion.

@bhilbert4 bhilbert4 self-assigned this Dec 29, 2023
@pep8speaks
Copy link

pep8speaks commented Dec 29, 2023

Hello @bhilbert4, Thank you for updating !

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated at 2023-12-29 22:31:20 UTC

@bhilbert4
Copy link
Collaborator Author

The conflicts above are just because I alphabetized the list of anomalies, and git can't handle it.

@bhilbert4
Copy link
Collaborator Author

bhilbert4 commented Jan 3, 2024

Passed a query to @rcooper295, asking if NIRISS would be ok changing their "snowball" anomaly to "unusual snowball", and "cosmic ray shower" to "unusual cosmic ray", to match the proposed NIRSpec changes here. NIRCam is fine with these changes. I think that keeping common terms as much as possible would be helpful and I think those changes make sense for all the NIR instruments.

Before this is merged, there are database updates that will need to happen. Will need @BradleySappington 's help for those.

@mfixstsci mfixstsci closed this Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update NIRSpec anomaly flags
3 participants