Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visit Filter on query and archive thumbnails pages #1412

Merged

Conversation

BradleySappington
Copy link
Collaborator

Add new "visit" filter to thumbnail pages on archive and query result

@BradleySappington BradleySappington changed the title filter thumbnails on visit Visit Filter on query and archive thumbnails pages Dec 14, 2023
@BradleySappington
Copy link
Collaborator Author

Screenshot 2023-12-14 at 12 26 59 PM

@BradleySappington
Copy link
Collaborator Author

@mfixstsci @bhilbert4 - Ready for review

Copy link
Collaborator

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks like adding the visit selection was fairly straight forward. Thanks for the submission @BradleySappington!

@pep8speaks
Copy link

pep8speaks commented Dec 18, 2023

Hello @BradleySappington, Thank you for updating !

Line 410:13: E128 continuation line under-indented for visual indent
Line 410:13: W503 line break before binary operator
Line 421:17: E128 continuation line under-indented for visual indent
Line 421:17: W503 line break before binary operator

Comment last updated at 2023-12-18 17:10:06 UTC

Copy link
Collaborator

@bhilbert4 bhilbert4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

jwql/website/apps/jwql/data_containers.py Show resolved Hide resolved
@BradleySappington BradleySappington merged commit e6023ec into spacetelescope:develop Dec 18, 2023
6 checks passed
@BradleySappington BradleySappington deleted the visit_filter branch December 18, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants