Merge pull request #17 from localhousee/main

feat: format newline on `message` function
spatie · Nov 7, 2022 · 2ea5720 · 2ea5720
2 parents 22e74ae + e06b25e
commit 2ea5720
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/src/DiscordAlert.php b/src/DiscordAlert.php
@@ -17,6 +17,8 @@ public function message(string $text): void
     {
         $webhookUrl = Config::getWebhookUrl($this->webhookUrlName);
 
+        $text = $this->parseNewline($text);
+
         $jobArguments = [
             'text' => $text,
             'webhookUrl' => $webhookUrl,
@@ -26,4 +28,9 @@ public function message(string $text): void
 
         dispatch($job);
     }
+
+    private function parseNewline(string $text): string
+    {
+        return str_replace('\n', PHP_EOL, $text);
+    }
 }
diff --git a/tests/DiscordAlertsTest.php b/tests/DiscordAlertsTest.php
@@ -53,3 +53,13 @@
 
     DiscordAlert::message('test-data');
 })->throws(JobClassDoesNotExist::class);
+
+it('will convert a newline string (\n) into a PHP_EOL constant', function() {
+    config()->set('discord-alerts.webhook_urls.default', 'https://test-domain.com');
+
+    DiscordAlert::message('test \n data');
+
+    Bus::assertDispatched(function (SendToDiscordChannelJob $job) {
+        return $job->text === "test " . PHP_EOL . " data";
+    });
+});