Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just reduced transaction bits #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JimmyHoffa
Copy link

No description provided.

@JimmyHoffa
Copy link
Author

I see similar active and available code in other locations - the ergo pay reference implementation, the transaction builder, and the Nautilus wallet.

Go ahead and close this PR if you want to snag code from one of those more proven and tested implementations.

On a side note - I think getting some library like this moved into the ergo platform github group would be really ideal - seeing each consumer I mentioned above reimplementing these same sections gives me pause that there may not be an ideal centrally owned lib to provide such functionality that many need. Having this under ergolabs as opposed to the ergo platform group feels like a lost opportunity to communicate more broadly it's availability (or another libraries implementation if it would be preferable)

Copy link
Member

@oskin1 oskin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please merge ExplorerUnspentErgoBox and ExplorerErgoBox.

@@ -80,6 +82,88 @@ export function explorerBalanceToWallet(b: ExplorerBalance): Balance {
)
}

export type ExplorerUnspentErgoBox = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point in this one when there is a similar model ExplorerErgoBox?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants