golangci-lint: add gofmt #5738
Merged
golangci-lint: add gofmt #5738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that unlike goimports (which we already use and which includes most of the gofmt functionality), this gofmt linter is equivalent to "gofmt -s" i.e. including some code simplifications. Bring current code base into compliance with the new linter. Signed-off-by: Carlo Teubner <[email protected]>
c4rlo
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
|
We should consider https://github.com/mvdan/gofumpt. |
gofumpt is an interesting option. I would go ahead and introduce the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that unlike
goimports(which we already use and which includes most of thegofmtfunctionality), thisgofmtlinter is equivalent togofmt -si.e. including some code simplifications.Bring current code base into compliance with the new linter (by running
gofmt -w -son all affected files).