Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate integration testing to RBA paradigm - Step 2 #345

Merged
merged 7 commits into from
Jan 17, 2025

Conversation

cmcginley-splunk
Copy link
Collaborator

@cmcginley-splunk cmcginley-splunk commented Jan 16, 2025

Context

Code changes

  • Removed references to observables and adapted as appropriate for the new .rba structure
  • Role checking removed from risk validation as it is no longer relevant in this new paradigm

Testing

  • Spot checking against detections/endpoint/anomalous_usage_of_7zip.yml
  • Integration testing passed
  • Also contrived the following error scenarios and validated all were still caught
    • RBA does not exist -> functionally impossible as this is checked in validation
    • Two risk objects w/ the same field name
    • Unmatched risk object
    • Unmatched risk event
    • Unmatched analytic stories
    • Unmatched MITRE IDs
    • Pattern match failure on message string
    • Type mismatch on RBA object and risk event
    • Score mismatch RBA object and risk event
    • Field token in message string

…red code w/ comments for cleanup before merge
@cmcginley-splunk cmcginley-splunk changed the title initial commit; migrated integration testing to RBA structures; litte… Migrate integration testing to RBA paradigm - Step 2 Jan 16, 2025
@cmcginley-splunk cmcginley-splunk marked this pull request as draft January 16, 2025 00:34
@cmcginley-splunk cmcginley-splunk changed the title Migrate integration testing to RBA paradigm - Step 2 DRAFT: Migrate integration testing to RBA paradigm - Step 2 Jan 16, 2025
@cmcginley-splunk cmcginley-splunk changed the title DRAFT: Migrate integration testing to RBA paradigm - Step 2 Migrate integration testing to RBA paradigm - Step 2 Jan 16, 2025
@cmcginley-splunk cmcginley-splunk marked this pull request as ready for review January 16, 2025 22:48
Copy link
Contributor

@pyth0n1c pyth0n1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only looked so far from a static perspective and didn't have any additional comments.
I haven't had the chance to do any runtime testing yet and anticipate I will get to this first thing Friday morning.

@ljstella ljstella merged commit 0f53c69 into obs_to_rba Jan 17, 2025
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants