Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PR Template #3055

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Updated PR Template #3055

merged 2 commits into from
Jul 25, 2024

Conversation

ljstella
Copy link
Contributor

Details

Updates the PR Template to add a checklist item for lookup names, as well as a new "Notes for Submitters and Reviewers" about things to be aware of while prepping and reviewing an PR.

Checklist

  • Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
  • CI/CD jobs passed ✔️
  • Validated SPL logic.
  • Validated tags, description, and how to implement.
  • Verified references match analytic.

@patel-bhavin
Copy link
Contributor

Awesome! LGTM

@patel-bhavin patel-bhavin merged commit d3cf928 into develop Jul 25, 2024
7 checks passed
@patel-bhavin patel-bhavin deleted the pr_template_update branch July 25, 2024 15:12
@patel-bhavin patel-bhavin added this to the v4.37.0 milestone Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants