-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detection suspicious api / url from telegram #3263
base: develop
Are you sure you want to change the base?
Conversation
User who's using telegram if got phishing/suspicious api/ or suspicious url will detected
Hello: @zake1god - Thank you for the PR! Before we get these shipped we would like a few changes in the yaml file . I have left some comments inline! Can you give us an attack data set to test this detection? |
@@ -0,0 +1,100 @@ | |||
data_source: | |||
- Windows Security 4688 | |||
name: Telegram Detected Access Suspicious API/URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we re arrange the yaml keys to match the key order as the other yamls.
detections/endpoint/telegram_detected_access_suspicious_api_url.yml
Outdated
Show resolved
Hide resolved
detections/endpoint/telegram_detected_access_suspicious_api_url.yml
Outdated
Show resolved
Hide resolved
Developers testing Telegram API functionality in controlled environments. | ||
|
||
drilldown_searches: | ||
- name: Original Detection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way our drilldowns are setup currently is that we require these two drilldowns to be present by default. Can you replace the first ones with these two :
drilldown_searches: |
We can keep the other two drilldowns!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the first one and keep second and third. also change time with token
tests: | ||
- name: True Positive Test | ||
attack_data: | ||
- data: https://github.com/splunk/contentctl/wiki |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide an attack dataset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4688201331200x80200000000000001114SecurityDESKTOP-EOFJH6ADESKTOP-EOFJH6A\zakezakeDESKTOP-EOFJH6A0x2eb52c0x117cC:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe%%19380x206c"C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe" --single-argument https://api.telegram.org/NULL SID--0x0C:\Users\zake\AppData\Roaming\Telegram Desktop\Telegram.exeMandatory Label\Medium Mandatory Level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zake1god :In order to successfully test this detection we would need the raw logs can you export _raw logs from the Splunk instance that would trigger for this detection and add it in the appropriate location in the attack data repository?
Example PR of that attack data looks - like https://github.com/splunk/attack_data/pull/932/files.
In case you are unable to create this PR , please share the _raw data file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to hijack this thread. But @zake1god the event that you shared does not speak suspicious nor malicious. This is a browser opening a direct link to api.telegram.org
From the logic of your rule, you're looking for a child of telegram.exe having this argument which is expected of the telegram app itself.
A couple of general notes:
- The rule in its current logic state cannot be a TTP.
- The Telegram app accessing the API is expected from a network perspective but the reference that you cite is not actually mentioning anything about abuse of CommandLine but the abuse of telegram itself. Can you please explain the vector of abuse via the commandline that you are trying to detect?
fix drilldown and change index to macros `wineventlog_security`
remove lookups
declare macros wineventlog_security
add | in the first search
User who's using telegram if got phishing/suspicious api/ or suspicious url will detected
Details
What does this PR have in it? Screenshots are worth 1000 words 😄
Checklist
<platform>_<mitre att&ck technique>_<short description>
nomenclatureNotes For Submitters and Reviewers
build
CI job when it fails will likely show an error about what is failing. You may have a very descriptive error of the specific field(s) in the specific file(s) that is causing an issue. In some cases, its also possible there is an issue with the YAML. Many of these can be caught with the pre-commit hooks if you set them up. These errors will be less descriptive as to what exactly is wrong, but will give you a column and row position in a specific file where the YAML processing breaks. If you're having trouble with this, feel free to add a comment to your PR tagging one of the maintainers and we'll be happy to help troubleshoot it.