Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] PR: Add codecov token as a repo secret #250

Closed
wants to merge 1 commit into from

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Dec 7, 2023

Seems like coverage upload CI step is failing due to missing coverage token. Set token as secret and use it over the CI

@dalthviz dalthviz added this to the v1.3.0 milestone Dec 7, 2023
@dalthviz dalthviz self-assigned this Dec 7, 2023
@dalthviz dalthviz changed the title PR: Add codecov token as a repo secret [WIP] PR: Add codecov token as a repo secret Dec 7, 2023
@dalthviz
Copy link
Member Author

dalthviz commented Dec 7, 2023

Closing since seems like with a CI rerun made the coverage step to pass. Also, thinking about this, probably in the future a check to use a different service for code coverage could be worthy - codecov is kind of flaky sometimes 🤔

@dalthviz dalthviz closed this Dec 7, 2023
@dalthviz dalthviz removed this from the v1.3.0 milestone Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant