PR: Add initial pre-commit config file and fix CI (macOS image label and codecov token errors)
#265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
force-pushed
the
add_pre_commit
branch
2 times, most recently
from
ba4e38f to
3c97e90
Compare
dalthviz
force-pushed
the
add_pre_commit
branch
from
3c97e90 to
be12800
Compare
for more information, see https://pre-commit.ci
dalthviz
changed the title
pre-commit config filepre-commit config file
dalthviz
changed the title
pre-commit config filepre-commit config file and fix CI (macOS image label and codecov token errors)
dalthviz
changed the title
pre-commit config file and fix CI (macOS image label and codecov token errors)pre-commit config file and fix CI (macOS image label and codecov token errors)
|
@ccordoba12 is there anything missing with this or should I go ahead and merge it? |
|
Sorry @dalthviz, I forgot to review your PR when you submitted it. It looks good to me at first glance. My main recommendation is to add the commit hash |
ccordoba12
reviewed
Nov 24, 2024
Co-authored-by: Carlos Cordoba <[email protected]>
ccordoba12
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #260