Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] PR: Add remote-files capability to remote-client plugin #23381

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

hlouzada
Copy link
Contributor

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)

Add remote files system API using fsspec for the remote-client plugin.

Use a mixture of rest/websocket to comunicate with spyder-remote-services and
provide a filesystem-like API to control remote file system.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @hlouzada

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "d7e4319b5"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-kernels.git"
  branch:   "master"
  commit:   "d7e4319b5"
git-subrepo:
  version:  "0.4.9"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "cce3d93"
@pep8speaks
Copy link

pep8speaks commented Dec 30, 2024

Hello @hlouzada! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 101:1: W293 blank line contains whitespace
Line 105:1: W293 blank line contains whitespace
Line 108:1: W293 blank line contains whitespace
Line 111:80: E501 line too long (83 > 79 characters)

Line 487:1: W293 blank line contains whitespace
Line 492:1: W293 blank line contains whitespace
Line 495:1: W293 blank line contains whitespace
Line 526:29: E251 unexpected spaces around keyword / parameter equals
Line 526:31: E251 unexpected spaces around keyword / parameter equals

Line 12:80: E501 line too long (100 > 79 characters)
Line 18:1: E302 expected 2 blank lines, found 1
Line 30:80: E501 line too long (82 > 79 characters)
Line 32:1: E302 expected 2 blank lines, found 1
Line 47:80: E501 line too long (83 > 79 characters)
Line 57:80: E501 line too long (92 > 79 characters)
Line 58:78: W291 trailing whitespace
Line 59:80: E501 line too long (94 > 79 characters)
Line 60:80: E501 line too long (90 > 79 characters)
Line 61:80: E501 line too long (86 > 79 characters)
Line 71:80: E501 line too long (88 > 79 characters)
Line 72:80: E501 line too long (90 > 79 characters)
Line 73:1: W293 blank line contains whitespace
Line 81:80: E501 line too long (119 > 79 characters)
Line 82:1: W293 blank line contains whitespace
Line 108:80: E501 line too long (82 > 79 characters)
Line 112:80: E501 line too long (89 > 79 characters)
Line 113:1: W293 blank line contains whitespace
Line 123:1: W293 blank line contains whitespace
Line 126:1: W293 blank line contains whitespace
Line 176:80: E501 line too long (91 > 79 characters)
Line 176:80: E741 ambiguous variable name 'l'
Line 205:80: E501 line too long (80 > 79 characters)
Line 219:48: E252 missing whitespace around parameter equals
Line 219:49: E252 missing whitespace around parameter equals
Line 220:80: E501 line too long (128 > 79 characters)
Line 224:80: E501 line too long (90 > 79 characters)
Line 228:80: E501 line too long (92 > 79 characters)
Line 232:80: E501 line too long (92 > 79 characters)
Line 234:1: W293 blank line contains whitespace
Line 236:80: E501 line too long (91 > 79 characters)
Line 238:1: W293 blank line contains whitespace
Line 239:59: E252 missing whitespace around parameter equals
Line 239:60: E252 missing whitespace around parameter equals
Line 239:80: E252 missing whitespace around parameter equals
Line 239:80: E501 line too long (87 > 79 characters)
Line 239:81: E252 missing whitespace around parameter equals
Line 241:80: E501 line too long (91 > 79 characters)
Line 242:80: E501 line too long (93 > 79 characters)
Line 244:1: W293 blank line contains whitespace
Line 246:80: E501 line too long (94 > 79 characters)
Line 248:1: W293 blank line contains whitespace
Line 249:57: E252 missing whitespace around parameter equals
Line 249:58: E252 missing whitespace around parameter equals
Line 250:80: E501 line too long (80 > 79 characters)
Line 251:39: E128 continuation line under-indented for visual indent
Line 251:80: E501 line too long (98 > 79 characters)
Line 253:1: W293 blank line contains whitespace
Line 254:53: E252 missing whitespace around parameter equals
Line 254:54: E252 missing whitespace around parameter equals
Line 256:80: E501 line too long (93 > 79 characters)
Line 258:1: W293 blank line contains whitespace
Line 259:47: E252 missing whitespace around parameter equals
Line 259:48: E252 missing whitespace around parameter equals
Line 259:65: E252 missing whitespace around parameter equals
Line 259:66: E252 missing whitespace around parameter equals
Line 259:80: E501 line too long (113 > 79 characters)
Line 259:83: E252 missing whitespace around parameter equals
Line 259:84: E252 missing whitespace around parameter equals
Line 259:104: E252 missing whitespace around parameter equals
Line 259:105: E252 missing whitespace around parameter equals

Comment last updated at 2025-01-09 19:37:43 UTC

@hlouzada hlouzada changed the title Add remote-files capability to remote-client plugin [WIP] PR: Add remote-files capability to remote-client plugin Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants