Add a PostgreSQL based job server option to replace AMQP #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's likely safer for our job queue migration to have the DBHub.io daemons be able to run with either job queue system. That way if our new job queue code has problems we can revert to using AMQP until the problems are fixed. With this commit the daemons can run in either AMQP mode or job queue server mode. There's a hard coded boolean value near the top of common/live_amqp.go to switch between them. The Cypress tests pass in both modes, so things should be ok.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
justinclift
force-pushed
the
pg_job_queue_v3
branch
from
2d07050 to
b884f0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's likely safer for our job queue migration to have the DBHub.io daemons be able to run with either job queue system.
That way if our new job queue code has problems we can revert to using AMQP until the problems are fixed.
With this commit the daemons can run in either AMQP mode or PostgreSQL job queue mode. There's a hard coded boolean value near the top of common/live_amqp.go to switch between them.
The Cypress tests pass in both modes (in my local testing), so things should be ok either way.