Fix #460: fix < and > in JSX strings (#465)

squint-cljs · Feb 14, 2024 · c949aa4 · c949aa4
1 parent 9090664
commit c949aa4
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 ## Unreleased
 
 - [#462](https://github.com/squint-cljs/squint/issues/462): Add `"exports"` field to `package.json`
+- [#460](https://github.com/squint-cljs/squint/issues/460): escape `<` and `>` in JSX strings
 
 ## v0.6.90 (2024-02-06)
 

diff --git a/src/squint/compiler_common.cljc b/src/squint/compiler_common.cljc
@@ -139,7 +139,10 @@
   (cond-> (if (and (:jsx env)
                    (not (:jsx-attr env))
                    (not (:jsx-runtime env)))
-            expr
+            (str/replace expr #"([<>])" (fn [x]
+                                          (get
+                                           {"<" "&lt;"
+                                            ">" "&gt;"} (second x))))
             (emit-return (pr-str expr) env))
     (pos? (count expr)) (bool-expr)))
 

diff --git a/test/squint/jsx_test.cljs b/test/squint/jsx_test.cljs
@@ -64,7 +64,9 @@
       (App)"
           s (jss! cljs)]
       (is (str/includes? s "<div>{(squint_core.truth_(picked_emoji1))"))
-      (is (= "<div><div>Picker</div></div>" (test-jsx cljs))))))
+      (is (= "<div><div>Picker</div></div>" (test-jsx cljs)))))
+  (testing "less than, greater than"
+    (is (= "<div>&lt;&gt;</div>" (test-jsx "#jsx [:div \"<>\"]")))))