refactor: omit a few spec fields if empty

apis/v1alpha1/topologyspec.go

@@ -38,12 +38,12 @@ type Persistence struct {
 	// to make the claim smaller you must delete the topology (or the node from the topology) and
 	// re-add it.
 	// +optional
-	ClaimSize string `json:"claimSize"`
+	ClaimSize string `json:"claimSize,omitempty"`
 	// StorageClassName is the storage class to set in the PVC -- if not provided this will be left
 	// empty which will end up using your default storage class. Note that currently we assume you
 	// have (as default) or provide a dynamically provisionable storage class, hence no selector.
 	// +optional
-	StorageClassName string `json:"storageClassName"`
+	StorageClassName string `json:"storageClassName,omitempty"`
 }
 
 // InsecureRegistries is a slice of strings of insecure registries to configure in the launcher
@@ -55,10 +55,10 @@ type InsecureRegistries []string
 type Definition struct {
 	// Containerlab holds a valid containerlab topology.
 	// +optional
-	Containerlab string `json:"containerlab"`
+	Containerlab string `json:"containerlab,omitempty"`
 	// Kne holds a valid kne topology.
 	// +optional
-	Kne string `json:"kne"`
+	Kne string `json:"kne,omitempty"`
 }
 
 // Expose holds configurations relevant to how clabernetes exposes a topology.

clabverter/test-fixtures/golden/srl02.yaml

@@ -27,7 +27,6 @@ spec:
 
         links:
           - endpoints: ["srl1:e1-1", "srl2:e1-1"]
-    kne: ""
   deployment:
     containerlabDebug: false
     filesFromConfigMap:
@@ -53,9 +52,7 @@ spec:
         filePath: srl2.license
     filesFromURL: null
     persistence:
-      claimSize: ""
       enabled: false
-      storageClassName: ""
     privilegedLauncher: false
     resources: null
   expose:

e2e/topology/basic/test-fixtures/golden/10-topology.topology-basic.yaml

@@ -14,13 +14,10 @@ spec:
           srl1:
             kind: srl
             image: ghcr.io/nokia/srlinux
-    kne: ""
   deployment:
     containerlabDebug: false
     persistence:
-      claimSize: ""
       enabled: false
-      storageClassName: ""
     privilegedLauncher: false
   expose:
     disableAutoExpose: false