feat: tee node logs to pod logs #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellt
reviewed
Oct 20, 2023
| containerlabLogger claberneteslogging.Instance | ||
| nodeLogger claberneteslogging.Instance | ||
|
|
||
| containerIDs []string |
There was a problem hiding this comment.
I wonder, when are we having >1 container in a launcher pod?
There was a problem hiding this comment.
literally no idea :P but figured if/when that happens we'd want to care about them all. obviously we can easily just watch a single id at some point too!
hellt
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title. also writes them to node.log via the multi writer. does this for all containers on the pod -- that way if there is some setup w/ multiple containers we get all logs.